jjkiers/OAuth
1
0
Fork 0
Code Issues 2 Pull Requests 1 Packages Projects Releases 1 Wiki Activity

Remove parameter should be passed reference

Browse Source
This commit is contained in:
victorbjelkholm
2013-09-23 12:08:25 +02:00
committed by Jacob Kiers
parent cec7f31cda
commit da8c3c46c5
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/JacobKiers/OAuth/Server.php
View File

@@ -89,7 +89,7 @@ public function addSignatureMethod(SignatureMethodInterface $signature_method)
*
* @return JacobKiers\OAuth\Token\TokenInterface
*/
public function fetchRequestToken(RequestInterface &$request)
public function fetchRequestToken(RequestInterface $request)
{
$this->getVersion($request);
@@ -115,7 +115,7 @@ public function fetchRequestToken(RequestInterface &$request)
*
* @return JacobKiers\OAuth\Token\TokenInterface
*/
public function fetchAccessToken(RequestInterface &$request)
public function fetchAccessToken(RequestInterface $request)
{
$this->getVersion($request);
@@ -139,7 +139,7 @@ public function fetchAccessToken(RequestInterface &$request)
*
* @return array Consumer and Token
*/
public function verifyRequest(RequestInterface &$request)
public function verifyRequest(RequestInterface $request)
{
$this->getVersion($request);
$consumer = $this->getConsumer($request);
@@ -159,7 +159,7 @@ public function verifyRequest(RequestInterface &$request)
*
* @throws JacobKiers\OAuth\OAuthException
*/
private function getVersion(RequestInterface &$request)
private function getVersion(RequestInterface $request)
{
$version = $request->getOAuthVersion();
if (!$version) {

4
src/JacobKiers/OAuth/SignatureMethod/RsaSha1.php
View File

@@ -49,7 +49,7 @@ public function getName()
* Either way should return a string representation of the certificate
*
*/
abstract protected function fetchPublicCert(&$request);
abstract protected function fetchPublicCert($request);
/**
* Up to the SP to implement this lookup of keys. Possible ideas are:
@@ -57,7 +57,7 @@ abstract protected function fetchPublicCert(&$request);
*
* Either way should return a string representation of the certificate
*/
abstract protected function fetchPrivateCert(&$request);
abstract protected function fetchPrivateCert($request);
/**
* Build up the signature.